linux-kernel - Re: [PATCH 1/1] swiotlb: save io_tlb_used to local variable before leaving critical section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38f6f868-013e-5619-b939-a8273fc64ee4@oracle.com>
Date:   Mon, 15 Apr 2019 14:50:49 +0800
From:   Dongli Zhang <dongli.zhang@...cle.com>
To:     Joe Jin <joe.jin@...cle.com>, iommu@...ts.linux-foundation.org,
        konrad.wilk@...cle.com
Cc:     linux-kernel@...r.kernel.org, hch@....de, m.szyprowski@...sung.com,
        robin.murphy@....com, haakon.bugge@...cle.com
Subject: Re: [PATCH 1/1] swiotlb: save io_tlb_used to local variable before
 leaving critical section

As the patch to be fixed is still in Konrad's own tree, I will send the v2 for
the patch to be fixed, instead of an incremental fix.

Dongli Zhang

On 4/12/19 10:13 PM, Joe Jin wrote:
> I'm good to have this patch, which helps identify the cause of failure is
> fragmentation or it really been used up.
> 
> On 4/12/19 4:38 AM, Dongli Zhang wrote:
>> When swiotlb is full, the kernel would print io_tlb_used. However, the
>> result might be inaccurate at that time because we have left the critical
>> section protected by spinlock.
>>
>> Therefore, we backup the io_tlb_used into local variable before leaving
>> critical section.
>>
>> Fixes: 83ca25948940 ("swiotlb: dump used and total slots when swiotlb buffer is full")
>> Suggested-by: Håkon Bugge <haakon.bugge@...cle.com>
>> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>
> 
> Reviewed-by: Joe Jin <joe.jin@...cle.com> 
> 
> Thanks,
> Joe
>