linux-kernel - Re: [PATCH] clocksource: timer-probe: change log level to warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63ead988-cb06-ca14-6995-9d5405f3e562@linaro.org>
Date:   Tue, 16 Apr 2019 19:32:35 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Moses Christopher <moseschristopherb@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource: timer-probe: change log level to warn

On 16/04/2019 19:23, Moses Christopher wrote:
>   - In drivers/clocksource/timer-probe.c, the log level for the message
>     stating "no matching timers found" should be of warning(4) rather
>     than critical(2)
>   - Reference:
>      - https://e2e.ti.com/support/processors/f/791/t/726024
>      - As per the feedback received from Daniel Lezcano
> 
> Signed-off-by: Moses Christopher <moseschristopherb@...il.com>

Applied for 5.2 but massaged a bit the change log to comply with the
kernel submitting patches rules.

> ---
>  drivers/clocksource/timer-probe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-probe.c b/drivers/clocksource/timer-probe.c
> index 028075720334..246b45d22d08 100644
> --- a/drivers/clocksource/timer-probe.c
> +++ b/drivers/clocksource/timer-probe.c
> @@ -50,5 +50,5 @@ void __init timer_probe(void)
>  	timers += acpi_probe_device_table(timer);
>  
>  	if (!timers)
> -		pr_crit("%s: no matching timers found\n", __func__);
> +		pr_warn("%s: no matching timers found\n", __func__);
>  }
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog