linux-kernel - Re: [PATCH v4 3/4] perf stat: Support 'percore' event qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7141fd1-ea29-e6fc-6738-798c46b99d6b@linux.intel.com>
Date:   Tue, 16 Apr 2019 08:31:00 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v4 3/4] perf stat: Support 'percore' event qualifier



On 4/16/2019 3:26 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 15, 2019 at 08:09:09PM +0530, Ravi Bangoria escreveu:
>>
>>
>> On 4/12/19 7:29 PM, Jin Yao wrote:
>>> diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
>>> index 39c05f8..1e312c2 100644
>>> --- a/tools/perf/Documentation/perf-stat.txt
>>> +++ b/tools/perf/Documentation/perf-stat.txt
>>> @@ -43,6 +43,10 @@ report::
>>>   	  param1 and param2 are defined as formats for the PMU in
>>>   	  /sys/bus/event_source/devices/<pmu>/format/*
>>>   
>>> +	  'percore' is a event qualifier that sums up the event counts for both
>>> +	  hardware threads in a core.
>>
>> s/both/all/  :
>>
>>    $ lscpu | grep Thread
>>    Thread(s) per core:    4
>>
>>
>> Apart from that, for the series:
>> Tested-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
> 
> Yeah I had fixed up that already, fixed up the patch description this
> time around, "both" was being used there as well, changed to "all".
> 
> Thanks, added your Tested-by tag, appreciated.
> 
> - Arnaldo
> 

Thanks Ravi, Thanks Arnaldo!