linux-kernel - Re: [PATCH v2 2/3] blk-mq.c: Rework documention of blk_mq_init_sq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1D00DC34-FC88-4F47-BB9F-A953A05794FD@wdc.com>
Date:   Tue, 16 Apr 2019 03:33:36 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [PATCH v2 2/3] blk-mq.c: Rework documention of
 blk_mq_init_sq_queue function

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>

On 4/15/19, 8:28 PM, "linux-block-owner@...r.kernel.org on behalf of Marcos Paulo de Souza" <linux-block-owner@...r.kernel.org on behalf of marcos.souza.org@...il.com> wrote:

    Describing better what the function does, what the arguments are meant for, and
    what SQ stands for.
    
    Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>
    ---
    
     Changes from v1:
     * Change "SQ" to "only one hw_queue (SQ)" in the function signature
     	documentation (suggested by Chaitanya)
    
     block/blk-mq.c | 17 ++++++++++++++---
     1 file changed, 14 insertions(+), 3 deletions(-)
    
    diff --git a/block/blk-mq.c b/block/blk-mq.c
    index 4a8277a54c03..3f13cfb47cf0 100644
    --- a/block/blk-mq.c
    +++ b/block/blk-mq.c
    @@ -2675,9 +2675,20 @@ struct request_queue *blk_mq_init_queue(struct blk_mq_tag_set *set)
     }
     EXPORT_SYMBOL(blk_mq_init_queue);
     
    -/*
    - * Helper for setting up a queue with mq ops, given queue depth, and
    - * the passed in mq ops flags.
    +/**
    + * blk_mq_init_sq_queue - Create a new request queue with only one hw_queue (SQ)
    + * @set: tag set to be associated by the newly created request queue
    + * @ops: operations to be associated with @set
    + * @queue_depth: number of tags of @set
    + * @set_flags: flags of @set
    + *
    + * Description:
    + * @set is initialized using @ops, @queue_depth, @set_flags, and using only one
    + * hw_queue (SQ). Later on blk_mq_alloc_tag_set() is called to validate and/or
    + * adjust values of the tag set. blk_mq_init_queue() is called passing @set as
    + * argument, returning a new request queue with @set associated.
    + *
    + * Returns the newly created request queue on success, or ERR_PTR() on failure.
      */
     struct request_queue *blk_mq_init_sq_queue(struct blk_mq_tag_set *set,
     					   const struct blk_mq_ops *ops,
    -- 
    2.16.4