linux-kernel - Re: [PATCH] perf tools: Fix perf_env__find_bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48CA4238-740E-4B42-BDB1-C2DD85A558C3@fb.com>
Date:   Tue, 16 Apr 2019 20:25:17 +0000
From:   Song Liu <songliubraving@...com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
CC:     Jiri Olsa <jolsa@...hat.com>, Jiri Olsa <jolsa@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] perf tools: Fix perf_env__find_bpf_prog_info rb tree
 lookup



> On Apr 16, 2019, at 7:37 AM, Arnaldo Carvalho de Melo <arnaldo.melo@...il.com> wrote:
> 
> Em Tue, Apr 16, 2019 at 11:35:54AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Tue, Apr 16, 2019 at 04:34:52PM +0200, Jiri Olsa escreveu:
>>> On Tue, Apr 16, 2019 at 11:20:28AM -0300, Arnaldo Carvalho de Melo wrote:
>>>> Em Tue, Apr 16, 2019 at 03:41:51PM +0200, Jiri Olsa escreveu:
>>>>> We currently don't return NULL in case we don't find
>>>>> the bpf_prog_info_node, fixing that.
>>>> 
>>>> Can you please try to figure out what was the changeset that introduced
>>>> this problem so that we can have a Fixes: tag that helps me determine if
>>>> this should go to perf/urgent (likely) or (perf/core) and to help the
>>>> stable guys as well?
>>> 
>>> sry, I keep forgetting this..
>>> 
>>> Fixes: e4378f0cb90b ("perf bpf: Save bpf_prog_info in a rbtree in perf_env")
>> 
>> I had just added:
>> 
>> Fixes: e4378f0cb90b ("perf bpf: Save bpf_prog_info in a rbtree in perf_env")
>> 
>> matches, good :-)
>> 
>> At firts I thought hey the look checks for NULL, then, hey, different
>> variable... good catch!
> 
> Ah, I also changed the summary from:
> 
>   "perf tools: Fix perf_env__find_bpf_prog_info rb tree"
> 
> to:
> 
>  perf bpf: Return NULL when RB tree lookup fails in perf_env__find_bpf_prog_info()
> 
> Thanks,
> 
> - Arnaldo

Thanks Jiri and Arnaldo!

I think we will need similar fix for perf_env__find_btf(). 

Song