linux-kernel - Re: [PATCH v2 06/16] watchdog: hpwdt: drop warning after calling watchdog_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190416205533.GB8268@kunai>
Date:   Tue, 16 Apr 2019 22:55:33 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Jerry Hoemann <jerry.hoemann@....com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-watchdog@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 06/16] watchdog: hpwdt: drop warning after calling
 watchdog_init_timeout


> That is indeed a problem: the pointer will be NULL if there is no parent
> device (such as in softdog.c). Otherwise it should never be NULL.

Okay, this spoils my err_dev solution. So, we probably go this route
then:

	pr_<errlvl>("watchdog%d: <err_msg>\n", wdd->id);

?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)