linux-kernel - Re: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd36b798-d129-c81a-ab2d-22a5b46567f6@metux.net>
Date:   Tue, 16 Apr 2019 23:05:40 +0200
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee.jones@...aro.org>, mark.rutland@....com,
        Andreas Färber <afaerber@...e.de>,
        treding@...dia.com, David Lechner <david@...hnology.com>,
        noralf@...nnes.org, johan@...nel.org,
        Michal Simek <monstr@...str.eu>, michal.vokac@...ft.com,
        Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>, john.garry@...wei.com,
        geert+renesas@...der.be, robin.murphy@....com,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        sebastien.bourdelin@...oirfairelinux.com, icenowy@...c.io,
        Stuart Yoder <stuyoder@...il.com>,
        "J. Kiszka" <jan.kiszka@...mens.com>, maxime.ripard@...tlin.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller

On 16.04.19 20:35, Sven Van Asbroeck wrote:

Hi,

> The "CAN stuff" is just a binary power read-out, routed from an external CAN
> card, which may or may not be present. The CAN card is not accessed from
> within this driver. This situation arises because our h/w developer team
> decided to integrate various unrelated pieces of functionality into the
> same hardware card (even into the same 8-bit register).

BRRR!

> This arcx-anybus controller card has two unrelated pieces of functionality:
> 1. implements an anybus-s slot
> 2. implements a power read-out from an external CAN card

So, it's an mfd (multi function device) ... hmm.

By the grey theory it would be better to split it into two separate
drivers. But obviously, they need need a common part (a third piece).

Does it ever make sense to only use one of two functionalities ?

Does this power read-out involve some CAN traffic, or is it just
fetching from some card that just happens to be some CAN interface ?
(IOW: is cansocket needed for that ?)


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287