linux-kernel - Re: [PATCH 2/2] x86/resctrl: Initialize new resource group with default MBA values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2817a0d5-fcaf-dc6c-8b01-4a423bd2e961@intel.com>
Date:   Wed, 17 Apr 2019 05:11:09 +0800
From:   Xiaochen Shen <xiaochen.shen@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        tony.luck@...el.com, fenghua.yu@...el.com,
        reinette.chatre@...el.com, x86@...nel.org,
        linux-kernel@...r.kernel.org, pei.p.jia@...el.com,
        xiaochen.shen@...el.com
Subject: Re: [PATCH 2/2] x86/resctrl: Initialize new resource group with
 default MBA values

Hi Boris,

On 4/17/2019 4:59, Borislav Petkov wrote:
> I guess but be conservative when adding too many words to a function's
> name - that might get heavy when reading the code later.
> 
> For example, there's an argument to not suffix it with "_cat": it is
> only called by rdtgroup_init_cat() - rdtgroup_init_mba() will not call
> it - so the path will remain unique anyway...
> 

I got it. I will use the function name "__init_one_rdt_domain()" you 
suggested.

Thank you.

> Anyway, something to think about - I personally don't have a strong
> preference here.


Best regards,
Xiaochen