linux-kernel - Re: [RFC PATCH 44/62] bpf: switch to ->free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Apr 2019 14:34:35 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Daniel Borkmann <daniel@...earbox.net>,
        bpf <bpf@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-Fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [RFC PATCH 44/62] bpf: switch to ->free_inode()

On Tue, Apr 16, 2019 at 11:07 AM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Tue, Apr 16, 2019 at 10:55 AM Al Viro <viro@...iv.linux.org.uk> wrote:
> >
> > From: Al Viro <viro@...iv.linux.org.uk>
> >
> > Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Acked-by: Song Liu <songliubraving@...com>

>
> > ---
> >  kernel/bpf/inode.c | 10 ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c
> > index 4a8f390a2b82..bc53e5b20ddc 100644
> > --- a/kernel/bpf/inode.c
> > +++ b/kernel/bpf/inode.c
> > @@ -566,9 +566,8 @@ static int bpf_show_options(struct seq_file *m, struct dentry *root)
> >         return 0;
> >  }
> >
> > -static void bpf_destroy_inode_deferred(struct rcu_head *head)
> > +static void bpf_free_inode(struct inode *inode)
> >  {
> > -       struct inode *inode = container_of(head, struct inode, i_rcu);
> >         enum bpf_type type;
> >
> >         if (S_ISLNK(inode->i_mode))
> > @@ -578,16 +577,11 @@ static void bpf_destroy_inode_deferred(struct rcu_head *head)
> >         free_inode_nonrcu(inode);
> >  }
> >
> > -static void bpf_destroy_inode(struct inode *inode)
> > -{
> > -       call_rcu(&inode->i_rcu, bpf_destroy_inode_deferred);
> > -}
> > -
> >  static const struct super_operations bpf_super_ops = {
> >         .statfs         = simple_statfs,
> >         .drop_inode     = generic_delete_inode,
> >         .show_options   = bpf_show_options,
> > -       .destroy_inode  = bpf_destroy_inode,
> > +       .free_inode     = bpf_free_inode,
> >  };
> >
> >  enum {
> > --
> > 2.11.0
> >