linux-kernel - Re: [PATCH 3/3] hwmon (occ): Add more details to Kconfig help text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190416221511.GA32220@roeck-us.net>
Date:   Tue, 16 Apr 2019 15:15:11 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eddie James <eajames@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        jdelvare@...e.com, andrew@...id.au, mine260309@...il.com,
        Eddie James <eajames@...ibm.com>
Subject: Re: [PATCH 3/3] hwmon (occ): Add more details to Kconfig help text

On Tue, Apr 16, 2019 at 03:43:50PM +0000, Eddie James wrote:
> From: Eddie James <eajames@...ibm.com>
> 
> The help text needs to spell out how the driver runs on a BMC, as it
> previously seemed to indicate it ran on a POWER processor.
> 
> Signed-off-by: Eddie James <eajames@...ibm.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/occ/Kconfig | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hwmon/occ/Kconfig b/drivers/hwmon/occ/Kconfig
> index 2a3869f..1658634 100644
> --- a/drivers/hwmon/occ/Kconfig
> +++ b/drivers/hwmon/occ/Kconfig
> @@ -9,8 +9,10 @@ config SENSORS_OCC_P8_I2C
>  	select SENSORS_OCC
>  	help
>  	 This option enables support for monitoring sensors provided by the
> -	 On-Chip Controller (OCC) on a POWER8 processor. Communications with
> -	 the OCC are established through I2C bus.
> +	 On-Chip Controller (OCC) on a POWER8 processor. However, this driver
> +	 can only run on a baseboard management controller (BMC) connected to
> +	 the P8, not the POWER processor itself. Communications with the OCC are
> +	 established through I2C bus.
>  
>  	 This driver can also be built as a module. If so, the module will be
>  	 called occ-p8-hwmon.
> @@ -22,8 +24,10 @@ config SENSORS_OCC_P9_SBE
>  	select SENSORS_OCC
>  	help
>  	 This option enables support for monitoring sensors provided by the
> -	 On-Chip Controller (OCC) on a POWER9 processor. Communications with
> -	 the OCC are established through SBE fifo on an FSI bus.
> +	 On-Chip Controller (OCC) on a POWER9 processor. However, this driver
> +	 can only run on a baseboard management controller (BMC) connected to
> +	 the P9, not the POWER processor itself. Communications with the OCC are
> +	 established through SBE fifo on an FSI bus.
>  
>  	 This driver can also be built as a module. If so, the module will be
>  	 called occ-p9-hwmon.