linux-kernel - Re: [PATCH v15 1/3] /proc/pid/status: Add support for architecture specific output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190416160143.8292ced993dc803aae7fa0da@linux-foundation.org>
Date:   Tue, 16 Apr 2019 16:01:43 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Aubrey Li <aubrey.li@...ux.intel.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, peterz@...radead.org,
        hpa@...or.com, ak@...ux.intel.com, tim.c.chen@...ux.intel.com,
        dave.hansen@...el.com, arjan@...ux.intel.com, adobriyan@...il.com,
        aubrey.li@...el.com, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v15 1/3] /proc/pid/status: Add support for architecture
 specific output

On Tue, 16 Apr 2019 14:32:48 +0800 Aubrey Li <aubrey.li@...ux.intel.com> wrote:

> The architecture specific information of the running processes could
> be useful to the userland. Add support to examine process architecture
> specific information externally.

The implementation looks just fine to me.  Have you had any feedback on
the overall desirability of adding this feature?

> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -96,6 +96,11 @@
>  #include <asm/processor.h>
>  #include "internal.h"
>  
> +/* Add support for architecture specific output in /proc/pid/status */
> +#ifndef	arch_proc_pid_status
> +#define	arch_proc_pid_status(m, task)
> +#endif

To this I suggest adding

/* arch_proc_pid_status() must be defined in asm/processor.h */

Because we've regularly had different architectures defining such things
in different headers, resulting in a mess.