linux-kernel - Re: [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34d02ae0-7182-2983-b601-acbdb4085f33@ce.jp.nec.com>
Date:   Tue, 16 Apr 2019 22:44:32 +0000
From:   Junichi Nomura <j-nomura@...jp.nec.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     Dave Young <dyoung@...hat.com>,
        Chao Fan <fanc.fnst@...fujitsu.com>,
        Baoquan He <bhe@...hat.com>, Kairui Song <kasong@...hat.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] x86/boot: Use efi_setup_data for searching RSDP on
 kexec-ed kernel

On 4/16/19 6:40 PM, Borislav Petkov wrote:
> On Mon, Apr 15, 2019 at 11:00:25PM +0000, Junichi Nomura wrote:
>> I thought we should hang here instead of return so that we
>> don't run into efi_get_rsdp_addr() in case of kexec.
> 
> Hanging that early without debug output is not very friendly to
> debuggers, methinks.

Right. But if we could move get_rsdp_addr() after console_init(),
you get debug output.

-- 
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.