linux-kernel - [PATCH V7 2/4] USB: serial: f81232: fix interrupt worker not stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1555403225-3430-2-git-send-email-hpeter+linux_kernel@gmail.com>
Date:   Tue, 16 Apr 2019 16:27:03 +0800
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
To:     peter_hong@...tek.com.tw, johan@...nel.org,
        gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: [PATCH V7 2/4] USB: serial: f81232: fix interrupt worker not stop

The F81232 will use LSR/Interrupt worker to handle LSR error & MSR
change. This patch will fix the interrupt work should stop in close()
and suspend().

Cc: Johan Hovold <johan@...nel.org>
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@...il.com>
---
V7:
	1: first introduce to this series patch.

 drivers/usb/serial/f81232.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 18d3fcf2907a..7c7495ae5600 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -576,6 +576,7 @@ static void f81232_close(struct usb_serial_port *port)
 	usb_serial_generic_close(port);
 	usb_kill_urb(port->interrupt_in_urb);
 	flush_work(&port_priv->lsr_work);
+	flush_work(&port_priv->interrupt_work);
 	port_priv->is_port_open = false;
 
 	mutex_unlock(&port_priv->lock);
@@ -679,8 +680,10 @@ static int f81232_suspend(struct usb_serial *serial, pm_message_t message)
 
 	usb_kill_urb(port->interrupt_in_urb);
 
-	if (port_priv)
+	if (port_priv) {
 		flush_work(&port_priv->lsr_work);
+		flush_work(&port_priv->interrupt_work);
+	}
 
 	return 0;
 }
-- 
2.7.4