linux-kernel - Re: [PATCH 06/12] i2c: omap: Add the master_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190416105221.c7h4ktzzu4xmdht3@ninjato>
Date:   Tue, 16 Apr 2019 12:52:21 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Stefan Lengfeld <contact@...fanchrist.eu>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Peter Rosin <peda@...ntia.se>, linux-omap@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Tero Kristo <t-kristo@...com>, Keerthy <j-keerthy@...com>,
        Simon Horman <horms+renesas@...ge.net.au>
Subject: Re: [PATCH 06/12] i2c: omap: Add the master_xfer_irqless hook


> the subject line of this patch
> 
>     i2c: omap: Add the master_xfer_irqless hook
> 
> still contains the old name of the callback '_irqless'. It should be
> '_atomic' instead.
> 
> 
> On Wed, Apr 03, 2019 at 02:40:13PM +0200, Wolfram Sang wrote:
> > Add the master_xfer_irqless hook to enable i2c transactions
> 
> Here again. It should be 'master_xfer_atomic'.

Yes, thanks, fixed!

> >  static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
> > -			     struct i2c_msg *msg, int stop)
> > +			     struct i2c_msg *msg, int stop, bool polling)
> 
> Nitpick. In the patches for the other drivers the boolean flag is called
> 'atomic' and not 'polling'.

This patch originally is not from me, so I prefer to not change it.
Also, I don't want to enforce strict naming within drivers. As long as
it is readable, I am fine with it.

> >  static const struct i2c_algorithm omap_i2c_algo = {
> > -	.master_xfer	= omap_i2c_xfer,
> > +	.master_xfer	= omap_i2c_xfer_irq,
> > +	.master_xfer_atomic	= omap_i2c_xfer_polling,
> 
> When consistency with other drivers is a goal, the functions should be
> named like:
> 
>     .master_xfe = omap_i2c_xfer,
>     .master_xfer_atomic = omap_i2c_xfer_atomic,
> 
> The first without a suffix and the second with the '_atomic' suffix.

ditto.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)