linux-kernel - Re: [PATCH v2] nvmem: core: add NVMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06b77a2d-a675-965d-224f-14ad8d9df106@codeaurora.org>
Date:   Tue, 16 Apr 2019 16:45:54 +0530
From:   Gaurav Kohli <gkohli@...eaurora.org>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     gregkh@...uxfoundation.org, maxime.ripard@...tlin.com,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig

Hi ,

I have reviewed and tested for both enabled and disabled and working as 
expected.

Please feel free to add:

Reviewed-by: Gaurav Kohli <gkohli@...eaurora.org>
Tested-by: Gaurav Kohli <gkohli@...eaurora.org>

Regards
Gaurav
On 4/16/2019 4:31 PM, Mika Westerberg wrote:
> On Tue, Apr 16, 2019 at 10:59:24AM +0100, Srinivas Kandagatla wrote:
>> Many nvmem providers are not very keen on having default sysfs
>> nvmem entry, as most of the usecases for them are inside kernel
>> itself. And in some cases read/writes to some areas in nvmem are
>> restricted and trapped at secure monitor level, so accessing them
>> from userspace would result in board reboots.
>>
>> This patch adds new NVMEM_SYSFS Kconfig to make binary sysfs entry
>> an optional one. This provision will give more flexibility to users.
>> This patch also moves existing sysfs code to a new file so that its
>> not compiled in when its not really required.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> 

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.