linux-kernel - Re: [PATCH] Staging: mt7621-mmc: Use DIV_ROUND_UP in function msdc_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Apr 2019 13:44:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Madhumitha Prabakaran <madhumithabiw@...il.com>
Cc:     matthias.bgg@...il.com, devel@...verdev.osuosl.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: mt7621-mmc: Use DIV_ROUND_UP in function
 msdc_set_mclk

On Wed, Apr 03, 2019 at 10:16:08AM -0500, Madhumitha Prabakaran wrote:
> Use DIV_ROUND_UP to make code simple and more understandable.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@...il.com>
> ---
>  drivers/staging/mt7621-mmc/sd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> index 4b26ec896a96..b12ed2c988fd 100644
> --- a/drivers/staging/mt7621-mmc/sd.c
> +++ b/drivers/staging/mt7621-mmc/sd.c
> @@ -240,7 +240,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
>  			div  = 1;         /* mean div = 1/4 */
>  			sclk = hclk >> 2; /* sclk = clk / 4 */
>  		} else {
> -			div  = (hclk + ((hz << 2) - 1)) / (hz << 2);
> +			div  = DIV_ROUND_UP(hclk, (hz << 2));
>  			sclk = (hclk >> 2) / div;
>  		}
>  	} else if (hz >= hclk) { /* bug fix */
> @@ -253,7 +253,7 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
>  			div  = 0;         /* mean div = 1/2 */
>  			sclk = hclk >> 1; /* sclk = clk / 2 */
>  		} else {
> -			div  = (hclk + ((hz << 2) - 1)) / (hz << 2);
> +			div  = DIV_ROUND_UP(hclk, (hz << 2));
>  			sclk = (hclk >> 2) / div;
>  		}
>  	}

This file is no longer in the kernel tree :(