linux-kernel - Re: [PATCH] perf: Remove duplicate headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqt6zaX5LT79o7exTxVQhLiSwBRFqtqmaJNwuE+hqs3j-XZdA@mail.gmail.com>
Date:   Tue, 16 Apr 2019 17:27:53 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Mukesh Ojha <mojha@...eaurora.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, acme@...nel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        namhyung@...nel.org, ak@...ux.intel.com,
        Stephane Eranian <eranian@...gle.com>,
        linux-kernel@...r.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        Brajeswar Ghosh <brajeswar.linux@...il.com>
Subject: Re: [PATCH] perf: Remove duplicate headers

On Sun, Apr 7, 2019 at 12:20 AM Mukesh Ojha <mojha@...eaurora.org> wrote:
>
>
> On 4/6/2019 7:06 PM, Souptick Joarder wrote:
> > Removed duplicate headers which are included twice.
> > Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

If no further comment, can we get this patch in queue for 5.2 ?

>
> Cheers,
> -Mukesh
>
> > ---
> >   tools/perf/util/data.c                 | 1 -
> >   tools/perf/util/get_current_dir_name.c | 1 -
> >   tools/perf/util/stat-display.c         | 1 -
> >   3 files changed, 3 deletions(-)
> >
> > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> > index 6a64f71..509a41e 100644
> > --- a/tools/perf/util/data.c
> > +++ b/tools/perf/util/data.c
> > @@ -8,7 +8,6 @@
> >   #include <unistd.h>
> >   #include <string.h>
> >   #include <asm/bug.h>
> > -#include <sys/types.h>
> >   #include <dirent.h>
> >
> >   #include "data.h"
> > diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> > index 267aa60..ebb80cd 100644
> > --- a/tools/perf/util/get_current_dir_name.c
> > +++ b/tools/perf/util/get_current_dir_name.c
> > @@ -5,7 +5,6 @@
> >   #include "util.h"
> >   #include <unistd.h>
> >   #include <stdlib.h>
> > -#include <stdlib.h>
> >
> >   /* Android's 'bionic' library, for one, doesn't have this */
> >
> > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > index 6d043c7..7b3a16c 100644
> > --- a/tools/perf/util/stat-display.c
> > +++ b/tools/perf/util/stat-display.c
> > @@ -12,7 +12,6 @@
> >   #include "string2.h"
> >   #include "sane_ctype.h"
> >   #include "cgroup.h"
> > -#include <math.h>
> >   #include <api/fs/fs.h>
> >
> >   #define CNTR_NOT_SUPPORTED  "<not supported>"