linux-kernel - Re: [PATCH] mfd: sun6i-prcm: fix build warning for non-OF configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190416124152.374wjfd6nczlkagv@flea>
Date:   Tue, 16 Apr 2019 14:41:52 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Lee Jones <lee.jones@...aro.org>, Chen-Yu Tsai <wens@...e.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: sun6i-prcm: fix build warning for non-OF
 configurations

On Tue, Apr 16, 2019 at 02:24:59PM +0200, Arnd Bergmann wrote:
> When CONFIG_OF is disabled, we get a harmless warning about an
> unused variable:
>
> drivers/mfd/sun6i-prcm.c: In function 'sun6i_prcm_probe':
> drivers/mfd/sun6i-prcm.c:151:22: error: unused variable 'np' [-Werror=unused-variable]
>
> Remove the variable and open-code the value in the only place
> it is used, so it can get left out as well without CONFIG_OF.
>
> Fixes: a05a2e7998ab ("mfd: sun6i-prcm: Allow to compile with COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Maxime Ripard <maxime.ripard@...tlin.com>

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)