linux-kernel - Re: [PATCH] serial: sc16is7xx: fix unused label warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190416131101.GD7406@kroah.com>
Date:   Tue, 16 Apr 2019 15:11:01 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jiri Slaby <jslaby@...e.com>, Phil Elwell <phil@...pberrypi.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Stefan Potyra <Stefan.Potyra@...ktrobit.com>,
        Mao Wenan <maowenan@...wei.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: fix unused label warning

On Tue, Apr 16, 2019 at 02:33:14PM +0200, Arnd Bergmann wrote:
> A bugfix introduced a harmless warning:
> 
> drivers/tty/serial/sc16is7xx.c:1523:1: error: unused label 'err_spi' [-Werror,-Wunused-label]
> 
> Move each label inside the correct #ifdef.
> 
> Fixes: ac0cdb3d9901 ("sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/tty/serial/sc16is7xx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Someone sent this same patch a week earlier.  I'll merge yours into
it...

thanks,

greg k-h