lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4ae5b863-a6db-39bb-7654-6dd9b63c0d34@gmail.com> Date: Tue, 16 Apr 2019 16:44:53 +0300 From: Dmitry Osipenko <digetx@...il.com> To: Chanwoo Choi <cw00.choi@...sung.com>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, MyungJoo Ham <myungjoo.ham@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>, Tomeu Vizoso <tomeu.vizoso@...labora.com> Cc: linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org Subject: Re: [PATCH v2 04/19] PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe 16.04.2019 4:59, Chanwoo Choi пишет: > Hi, > > On 19. 4. 15. 오후 11:54, Dmitry Osipenko wrote: >> There is no real benefit from doing so, hence let's drop that rate setting >> for consistency. >> >> Signed-off-by: Dmitry Osipenko <digetx@...il.com> >> --- >> drivers/devfreq/tegra-devfreq.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c >> index 69581c9082d4..d62fb1b0d9bb 100644 >> --- a/drivers/devfreq/tegra-devfreq.c >> +++ b/drivers/devfreq/tegra-devfreq.c >> @@ -648,8 +648,6 @@ static int tegra_devfreq_probe(struct platform_device *pdev) >> return PTR_ERR(tegra->emc_clock); >> } >> >> - clk_set_rate(tegra->emc_clock, ULONG_MAX); >> - > > It seems like that initialize the emc_clock as the supported maximum clock. > But, if the rate for emc_clock initialized by either bootloader or clock driver > and it's well working until this code, actually, it is not necessary. > > Looks good to me. > Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com> EMC clock rate is set properly at a boot time on all Tegra's, thanks.
Powered by blists - more mailing lists