lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <13D59CF9CEBAF94592A12E8AE55501350A6159AD@DE02WEMBXB.internal.synopsys.com> Date: Tue, 16 Apr 2019 14:48:26 +0000 From: Vitor Soares <vitor.soares@...opsys.com> To: Boris Brezillon <boris.brezillon@...labora.com>, Vitor Soares <vitor.soares@...opsys.com> CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, "linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "pmeerw@...erw.net" <pmeerw@...erw.net>, "lars@...afoo.de" <lars@...afoo.de>, "knaack.h@....de" <knaack.h@....de>, "jic23@...nel.org" <jic23@...nel.org>, "lorenzo.bianconi83@...il.com" <lorenzo.bianconi83@...il.com>, "bbrezillon@...nel.org" <bbrezillon@...nel.org>, "rafael@...nel.org" <rafael@...nel.org>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "broonie@...nel.org" <broonie@...nel.org>, "joao.pinto@...opsys.com" <joao.pinto@...opsys.com> Subject: RE: [PATCH 2/3] i3c: Add i3c_get_device_id helper Hi Boris, From: Boris Brezillon <boris.brezillon@...labora.com> Date: Tue, Apr 16, 2019 at 07:18:25 > On Mon, 15 Apr 2019 21:19:40 +0200 > Vitor Soares <vitor.soares@...opsys.com> wrote: > > > This helper return the i3c_device_id structure in order the client > > have access to the driver data. > > > > Signed-off-by: Vitor Soares <vitor.soares@...opsys.com> > > --- > > drivers/i3c/device.c | 8 ++++++++ > > include/linux/i3c/device.h | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > > index 472be99..8ab8e4c 100644 > > --- a/drivers/i3c/device.c > > +++ b/drivers/i3c/device.c > > @@ -235,6 +235,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev) > > } > > EXPORT_SYMBOL_GPL(dev_to_i3cdev); > > > > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev) > > +{ > > + const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver); > > + > > + return i3cdrv->id_table; > > +} > > +EXPORT_SYMBOL_GPL(i3c_get_device_id); > > I think what you want is i3c_device_match_id(). I want the i3c_device_id struct of an i3c_device. What is the name that you suggest? >Just move the function > to drivers/i3c/device.c, export it and define its prototype in > include/i3c/device.h. You are right, this should go for the device side. > > > + > > /** > > * i3c_driver_register_with_owner() - register an I3C device driver > > * > > diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h > > index 7ee7e30..ee48886 100644 > > --- a/include/linux/i3c/device.h > > +++ b/include/linux/i3c/device.h > > @@ -211,6 +211,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv) > > > > struct device *i3cdev_to_dev(struct i3c_device *i3cdev); > > struct i3c_device *dev_to_i3cdev(struct device *dev); > > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev); > > > > static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev, > > void *data) Best regards, Vitor Soares
Powered by blists - more mailing lists