lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Apr 2019 18:04:53 +0200 From: Alexandre Belloni <alexandre.belloni@...tlin.com> To: Thomas Bogendoerfer <tbogendoerfer@...e.de> Cc: Joshua Kinard <kumba@...too.org>, Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] rtc: ds1685: use threaded interrupt On 16/04/2019 11:34:04+0200, Thomas Bogendoerfer wrote: > Handling of extended interrupts (kickstart, wake-up, ram-clear) was > moved off to a work queue, but the interrupts aren't acknowledged > in the interrupt handler. This leads to a deadlock, if driver > is used with interrupts. To fix this we use a threaded interrupt, get rid > of the work queue and do locking with just the rtc mutex lock. > > Fixes: aaaf5fbf56f1 ("rtc: add driver for DS1685 family of real time clocks") > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de> > --- > drivers/rtc/rtc-ds1685.c | 220 +++++++++++++++++++++------------------------ > include/linux/rtc/ds1685.h | 2 - > 2 files changed, 104 insertions(+), 118 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Powered by blists - more mailing lists