linux-kernel - Re: [2/3] ARM: hisi: check of_iomap and fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Apr 2019 18:09:17 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Nicholas Mc Guire <hofrat@...dl.org>,
        Russell King <linux@...linux.org.uk>, linux@...linux.org.uk
Cc:     Fabio Estevam <festevam@...il.com>,
        Janusz Krzysztofik <jmkrzyszt@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Tony Lindgren <tony@...mide.com>, linux-imx@....com,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [2/3] ARM: hisi: check of_iomap and fix missing of_node_put

> +++ b/arch/arm/mach-hisi/hotplug.c
> @@ -173,11 +173,15 @@  static bool hix5hd2_hotplug_init(void)
…
> +	ctrl_base = of_iomap(np, 0);
> +	of_node_put(np);
> +	if (!ctrl_base)
> +		return false;
> +
> +	return true;
>  }
>
>  void hix5hd2_set_cpu(int cpu, bool enable)

Would the use of a ternary operator be more succinct here?

+	return ctrl_base ? true : false;

Regards,
Markus