lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <cover.1555529640.git.Asmaa@mellanox.com>
Date:   Wed, 17 Apr 2019 15:59:18 -0400
From:   Asmaa Mnebhi <Asmaa@...lanox.com>
To:     minyard@....org
Cc:     Asmaa Mnebhi <Asmaa@...lanox.com>, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org
Subject: [PATCH v2 0/1] *** Add support for IPMB driver ***

Thank you for your feedback Corey. I have addressed your inlined comments.

I understand your suggestion for making this an I2C driver.
I can certainly make those changes once we hear back from the i2c mailing list.
My only concern is that the ipmb_write is responsible for
sending the response via SMBus, so it needs the total length of the message.
So we need to document that this driver requires that the user program
(it is attached) passes the msg length as the first byte in the message. 

Asmaa Mnebhi (1):
  Add support for IPMB driver

 drivers/char/ipmi/Kconfig        |   8 +
 drivers/char/ipmi/Makefile       |   1 +
 drivers/char/ipmi/ipmb_dev_int.c | 407 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 416 insertions(+)
 create mode 100644 drivers/char/ipmi/ipmb_dev_int.c

-- 
2.1.2

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ