linux-kernel - Re: [PATCH v3 10/26] compat_ioctl: use correct compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Apr 2019 22:21:11 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-fsdevel@...r.kernel.org, y2038@...ts.linaro.org,
        linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Donnellan <andrew.donnellan@....ibm.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        Frank Haverkamp <haver@...ux.ibm.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Shivasharan S <shivasharan.srikanteshwara@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Felipe Balbi <balbi@...nel.org>,
        Jerry Zhang <zhangjerry@...gle.com>,
        Vincent Pelletier <plr.vincent@...il.com>,
        Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
        Shen Jing <jingx.shen@...el.com>,
        linuxppc-dev@...ts.ozlabs.org, megaraidlinux.pdl@...adcom.com,
        linux-scsi@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 10/26] compat_ioctl: use correct compat_ptr()
 translation in drivers

On Tue, Apr 16, 2019 at 10:19:48PM +0200, Arnd Bergmann wrote:
> A handful of drivers all have a trivial wrapper around their ioctl
> handler, but don't call the compat_ptr() conversion function at the
> moment. In practice this does not matter, since none of them are used
> on the s390 architecture and for all other architectures, compat_ptr()
> does not do anything, but using the new compat_ptr_ioctl()
> helper makes it more correct in theory, and simplifies the code.
> 
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Acked-by: Andrew Donnellan <andrew.donnellan@....ibm.com>
> Acked-by: Felipe Balbi <felipe.balbi@...ux.intel.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/misc/cxl/flash.c            |  8 +-------
>  drivers/misc/genwqe/card_dev.c      | 23 +----------------------
>  drivers/scsi/megaraid/megaraid_mm.c | 28 +---------------------------
>  drivers/usb/gadget/function/f_fs.c  | 12 +-----------

ACK, provided that all their ioctls are taking pointers (which is
worth mentioning in commit message, assuming it's true)