linux-kernel - Re: [PATCH v3 08/26] compat_ioctl: add compat_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Apr 2019 23:34:48 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 08/26] compat_ioctl: add compat_ptr_ioctl()

On Wed, Apr 17, 2019 at 11:19 PM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Tue, Apr 16, 2019 at 10:19:46PM +0200, Arnd Bergmann wrote:
> > Many drivers have ioctl() handlers that are completely compatible between
> > 32-bit and 64-bit architectures, except for the argument that is passed
> > down from user space and may have to be passed through compat_ptr()
> > in order to become a valid 64-bit pointer.
> >
> > Using ".compat_ptr = compat_ptr_ioctl" in file operations should let
> > us simplify a lot of those drivers to avoid #ifdef checks, and convert
> > additional drivers that don't have proper compat handling yet.
>
> You forgot to mention that it even gets the previous commit to build ;-)
> IOW, that needs to be reordered.

Right. I had reordered the series multiple times and got this part wrong
in the end.

       Arnd