linux-kernel - Re: Need advice about do we need this if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <19402.1555487793@turing-police>
Date:   Wed, 17 Apr 2019 03:56:33 -0400
From:   "Valdis Klētnieks" <valdis.kletnieks@...edu>
To:     B1C0D8C0 AACEC2D2D3CDC5CDCACE 
        <alexander198961@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
cc:     kernelnewbies@...nelnewbies.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Need advice about do we need this if condition

On Wed, 17 Apr 2019 08:25:22 +0300

(Adding Al Viro and the linux-fsdevel lists, as at the very least, the manpage
for the syscall needs some clarification...)

> hello I am trying to fix https://bugzilla.kernel.org/show_bug.cgi?id=202935

So - convince us that it's in fact a "bug" and not a restriction.

> I found cause
> https://github.com/torvalds/linux/blob/master/fs/cifs/cifsfs.c#L1076 not
> sure is it correct to remove such condition ?

Does the CIFS protocol support copying from a file to another location in the
same file? Was it intended to work on *any* filesystem?

(For that matter, the manpage for the syscall is unclear on whether having both
file descriptors open on the same file is OK or not - for bonus ambiguity
points, there's exactly zero discussion of what happens if source and
destination overlap destructively).