linux-kernel - Re: [PATCH 3/4] hwmon: (pmbus) add support for IR35215

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zhopcrp0.fsf@babayev.com>
Date:   Tue, 16 Apr 2019 19:04:59 -0700
From:   Ruslan Babayev <ruslan@...ayev.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Ruslan Babayev <ruslan@...ayev.com>,
        Jean Delvare <jdelvare@...e.com>, xe-linux-external@...co.com,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] hwmon: (pmbus) add support for IR35215


Guenter Roeck writes:

>> +
>> +#include <linux/kernel.h>
>> +#include <linux/module.h>
>> +#include <linux/init.h>
>> +#include <linux/err.h>
>> +#include <linux/i2c.h>
>
> Alphabetic include file order please.

Sure

>> +
>> +static struct pmbus_driver_info ir3570b_info = {
>> +	.pages = 1,
>
> Either this ...
>
>> +	.format[PSC_VOLTAGE_IN] = linear,
>> +	.format[PSC_VOLTAGE_OUT] = linear,
>> +	.format[PSC_CURRENT_IN] = linear,
>> +	.format[PSC_CURRENT_OUT] = linear,
>> +	.format[PSC_POWER] = linear,
>> +	.format[PSC_TEMPERATURE] = linear,
>> +	.func[0] = IR3570B_FUNCS,
>> +	.func[1] = IR3570B_FUNCS,
>
> ... or this is wrong.

The latter is wrong. Thanks for catching it.