linux-kernel - Re: [PATCH 1/1] arm: mm: Export __sync_icache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190417103102.rl33skdknnqshcoj@shell.armlinux.org.uk>
Date:   Wed, 17 Apr 2019 11:31:02 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Heinrich Schuchardt <xypron.glpk@....de>,
        stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/1] arm: mm: Export __sync_icache_dcache() for
 xen-privcmd

On Wed, Apr 17, 2019 at 11:03:51AM +0100, Catalin Marinas wrote:
> On Wed, Apr 17, 2019 at 10:41:37AM +0100, Russell King wrote:
> > On Sun, Apr 14, 2019 at 10:51:09PM -0700, Christoph Hellwig wrote:
> > > On Sat, Apr 13, 2019 at 06:30:52PM +0200, Heinrich Schuchardt wrote:
> > > > This patch avoids
> > > > ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined!
> > > > observed when compiling v4.19.34.
> > > > 
> > > > The xen-privcmd driver, which can be modular, calls set_pte_at()
> > > > which in turn may call __sync_icache_dcache().
> > > 
> > > Maybe that really is a sign that it should not be modular..
> > 
> > This issue has been discussed several times, and this URL gives a list
> > of all messages on linux-arm-kernel that mention __sync_icache_dcache:
> > 
> > https://archive.armlinux.org.uk/lurker/search/20380101.000000.00000000@ml:linux-arm-kernel,sb:__sync_icache_dcache.en.html
> > 
> > At the beginning of March, Boris Ostrovsky pointed that another solution
> > is available that does not need architecture private symbols to be
> > exported.
> > 
> > Since I've already said in a previous thread that I don't want this
> > function exported, it seems the way forward is pretty obvious.
> 
> Arnd submitted a patch, not sure what happened to it:
> 
> https://lore.kernel.org/lkml/20190304204826.2414365-1-arnd@arndb.de/

Thanks Catalin, this is the "another solution" that I referred to above.
(You'll find the exact same URL in Boris' email.)

> I think this boils down to whether set_pte_at() is allowed to be called
> from loadable modules. If yes, __sync_icache_dcache() needs exporting,
> otherwise Arnd's patch makes the relevant code built-in (and, if merged,
> I'm happy to revert the similar export on arm64).

I think I've clearly expressed my opinion on that.  Hence why "the way
forward is pretty obvious."  I don't understand why we still have the
problem.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up