linux-kernel - Re: [PATCH -next] drm/lima: Make lima_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKGbVbu9GZeuLo1bjaT9cRqyR=bVU1GNLqJef0OKHq7pB9CZrg@mail.gmail.com>
Date:   Wed, 17 Apr 2019 10:42:12 +0800
From:   Qiang Yu <yuq825@...il.com>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        lima@...ts.freedesktop.org,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH -next] drm/lima: Make lima_sched_ops static

Thanks, patch is:
Reviewed-by: Qiang Yu <yuq825@...il.com>

I'll add a "Fix" tag and push it to drm-misc-next.

Regards,
Qiang

On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing <yuehaibing@...wei.com> wrote:
>
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
>  symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/gpu/drm/lima/lima_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
> index 97bd9c1..569f0a95 100644
> --- a/drivers/gpu/drm/lima/lima_sched.c
> +++ b/drivers/gpu/drm/lima/lima_sched.c
> @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
>         kmem_cache_free(pipe->task_slab, task);
>  }
>
> -const struct drm_sched_backend_ops lima_sched_ops = {
> +static const struct drm_sched_backend_ops lima_sched_ops = {
>         .dependency = lima_sched_dependency,
>         .run_job = lima_sched_run_job,
>         .timedout_job = lima_sched_timedout_job,
> --
> 2.7.4
>
>