linux-kernel - Re: [PATCH v11 2/7] anybus-s: support HMS Anybus-S bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2630e582-cc4b-764e-9f20-f5a2905fa4ab@metux.net>
Date:   Wed, 17 Apr 2019 17:25:52 +0200
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee.jones@...aro.org>, mark.rutland@....com,
        Andreas Färber <afaerber@...e.de>,
        treding@...dia.com, David Lechner <david@...hnology.com>,
        noralf@...nnes.org, johan@...nel.org,
        Michal Simek <monstr@...str.eu>, michal.vokac@...ft.com,
        Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>, john.garry@...wei.com,
        geert+renesas@...der.be, robin.murphy@....com,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        sebastien.bourdelin@...oirfairelinux.com, icenowy@...c.io,
        Stuart Yoder <stuyoder@...il.com>,
        "J. Kiszka" <jan.kiszka@...mens.com>, maxime.ripard@...tlin.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v11 2/7] anybus-s: support HMS Anybus-S bus

On 17.04.19 00:00, Sven Van Asbroeck wrote:

Hi,

>> But this port supports probing ?>> (so it's, bit like a single usb port w/o hub ;-))> > Yes, that's
exactly it.
Okay, then your approach introducing a bus_type is correct, IMHO.

>> I guess that things like introducing new bus types or device classes>> are something that subsystem maintainers wanna be aware of :)>>>
> fieldbus_dev is a new subsystem.
> At first I attempted to mainline the anybus-s drivers with a 'roll-your-own'
> userspace API, but the feedback I got was: this userspace API should
> really be generic... So this is my attempt to create a generic fieldbus_dev
> API !

Yes, it's an own class of devices, many other (semantically) simiar
devices out there. Therefore, an own subsystem for that is a good idea.

But: I'd rather call it it "iec61158" instead of fieldbus", as there're
lots of different fieldbus types (eg. MVB has pretty different semantics
than iec61158)

> It's almost certainly insufficient, but it's a start. Ideally, this
> should get lots of review from people in the industry, but response 
> to this patchset has been underwhelming. 

It's still a niche, at least for Linux. Only few people here ever had
their hands on such PLC systems.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287