linux-kernel - Re: [PATCH -next] ALSA: ps3: Remove set but not used variables 'start_vaddr' and 'pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Apr 2019 11:19:30 -0700
From:   Geoff Levand <geoff@...radead.org>
To:     Yue Haibing <yuehaibing@...wei.com>, perex@...ex.cz,
        tiwai@...e.com, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        alsa-devel@...a-project.org
Subject: Re: [PATCH -next] ALSA: ps3: Remove set but not used variables
 'start_vaddr' and 'pcm_index'

On 4/17/19 7:57 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warnings:
> 
> sound/ppc/snd_ps3.c: In function 'snd_ps3_program_dma':
> sound/ppc/snd_ps3.c:236:8: warning: variable 'start_vaddr' set but not used [-Wunused-but-set-variable]
> sound/ppc/snd_ps3.c: In function 'snd_ps3_pcm_open':
> sound/ppc/snd_ps3.c:529:6: warning: variable 'pcm_index' set but not used [-Wunused-but-set-variable]
> 
> They are never used and can be removed.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  sound/ppc/snd_ps3.c | 4 ----
>  1 file changed, 4 deletions(-)

Seems OK.  Thanks for submitting.

Acked-by: Geoff Levand <geoff@...radead.org>