linux-kernel - Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h8sw7riwt.wl-tiwai@suse.de>
Date:   Thu, 18 Apr 2019 07:17:54 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Jacek Anaszewski" <jacek.anaszewski@...il.com>
Cc:     <linux-leds@...r.kernel.org>, "Arnd Bergmann" <arnd@...db.de>,
        <dtor@...gle.com>, <robh@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, <linux@...ck-us.net>,
        <tiwai@...e.de>, <pavel@....cz>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace

On Wed, 17 Apr 2019 22:54:14 +0200,
Jacek Anaszewski wrote:
> 
> led_colors clashes with the array of the same name being added
> to the LED class. Do the following amendments to fix this issue
> and the other prospective one.
> 
> led_colors -> toneport_led_colors
> led_init_vals -> toneport_led_init_vals
> 
> Fixes: f44edd7b2bbed ("ALSA: line6/toneport: Implement LED controls via LED class")
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: Arnd Bergmann <arnd@...db.de>

Looks good.

Feel free to take my ack:
  Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi

> ---
>  sound/usb/line6/toneport.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/usb/line6/toneport.c b/sound/usb/line6/toneport.c
> index f47ba94e6f4a..56875526b182 100644
> --- a/sound/usb/line6/toneport.c
> +++ b/sound/usb/line6/toneport.c
> @@ -291,8 +291,8 @@ static bool toneport_has_led(struct usb_line6_toneport *toneport)
>  	}
>  }
>  
> -static const char * const led_colors[2] = { "red", "green" };
> -static const int led_init_vals[2] = { 0x00, 0x26 };
> +static const char * const toneport_led_colors[2] = { "red", "green" };
> +static const int toneport_led_init_vals[2] = { 0x00, 0x26 };
>  
>  static void toneport_update_led(struct usb_line6_toneport *toneport)
>  {
> @@ -320,9 +320,9 @@ static int toneport_init_leds(struct usb_line6_toneport *toneport)
>  
>  		led->toneport = toneport;
>  		snprintf(led->name, sizeof(led->name), "%s::%s",
> -			 dev_name(dev), led_colors[i]);
> +			 dev_name(dev), toneport_led_colors[i]);
>  		leddev->name = led->name;
> -		leddev->brightness = led_init_vals[i];
> +		leddev->brightness = toneport_led_init_vals[i];
>  		leddev->max_brightness = 0x26;
>  		leddev->brightness_set = toneport_led_brightness_set;
>  		err = led_classdev_register(dev, leddev);
> -- 
> 2.11.0
> 
>