linux-kernel - Re: [RFC PATCH 3/3] net: ethernet: ti: cpsw: add XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190418114426.0a0b26f9@cakuba.netronome.com>
Date:   Thu, 18 Apr 2019 11:44:26 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Cc:     grygorii.strashko@...com, linux-omap@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Netdev List <netdev@...r.kernel.org>,
        ilias.apalodimas@...aro.org, hawk@...nel.org,
        xdp-newbies@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        aniel@...earbox.net, John Fastabend <john.fastabend@...il.com>
Subject: Re: [RFC PATCH 3/3] net: ethernet: ti: cpsw: add XDP support

On Thu, 18 Apr 2019 21:30:44 +0300, Ivan Khoronzhuk wrote:
> >> Here another thing bothering me, I send it to queue 0 always, instead of
> >> taking cpu num. Not sure about this, but I expect to have some tx queue
> >> not bind to cpu and didn't find a way it can be changed dynamically in
> >> redirect.  
> >
> >Not sure I understand :)  
> 
> I mean, is there a capability to choose tx queue while XDP_REDIRECT or XDP_TX.
> 
> From what I've seen it's taken by:
> qidx = smp_processor_id();
> 
> What if I need to send classified traffic to hw queue 4 for instance...

I see, no we don't have any API for that, yet.  I think all NICs which
implement XDP REDIRECT today will allocate a single normal prio queue
per CPU..