lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 18 Apr 2019 13:34:16 -0700
From:   Stephen Boyd <>
To:     Michael Turquette <>,
        Stephen Boyd <>
        Miquel Raynal <>,
        Jerome Brunet <>,
        Russell King <>,
        Jeffrey Hugo <>,
        Chen-Yu Tsai <>,
        Matti Vaittinen <>
Subject: Re: [PATCH v4 1/9] clkdev: Hold clocks_mutex while iterating clocks list

Quoting Stephen Boyd (2019-04-12 11:31:42)
> We recently introduced a change to support devm clk lookups. That change
> introduced a code-path that used clk_find() without holding the
> 'clocks_mutex'. Unfortunately, clk_find() iterates over the 'clocks'
> list and so we need to prevent the list from being modified at the same
> time. Do this by holding the mutex and checking to make sure it's held
> while iterating the list.
> Note, we don't really care if the lookup is freed after we find it with
> clk_find() because we're just doing a pointer comparison, but if we did
> care we would need to keep holding the mutex while we dereference the
> clk_lookup pointer.
> Fixes: 3eee6c7d119c ("clkdev: add managed clkdev lookup registration")
> Cc: Miquel Raynal <>
> Cc: Jerome Brunet <>
> Cc: Russell King <>
> Cc: Michael Turquette <>
> Cc: Jeffrey Hugo <>
> Cc: Chen-Yu Tsai <>
> Cc: Matti Vaittinen <>
> Signed-off-by: Stephen Boyd <>
> ---

Applied to clk-fixes

Powered by blists - more mailing lists