linux-kernel - Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190418160651.40cb6a11186a6c6028e9d20d@linux-foundation.org>
Date:   Thu, 18 Apr 2019 16:06:51 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Douglas Anderson <dianders@...omium.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jason Wessel <jason.wessel@...driver.com>,
        Christophe Leroy <christophe.leroy@....fr>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        kgdb-bugreport@...ts.sourceforge.net,
        Johannes Weiner <hannes@...xchg.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Nicholas Mc Guire <hofrat@...dl.org>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in
 kdb summary

On Wed, 17 Apr 2019 15:37:49 +0900 Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> > It's pretty benign: Doug will still only get a single email.
> >
> >
> > checkpatch checks for duplicates cc's but I think it assumes that
> > things like
> >
> > Reported-by: fred
> > Tested-by: fred
> >
> > were intentional.
> >
> > It would perhaps be better for checkpatch to special-case the "Cc:
> > fred" tag and report a duplicated Cc: if fred was also mentioned in any
> > other tag.
> 
> Sorry, I do not understand what you mean.
> 
> 
> Douglas did not add any Cc: tag at all
> in his original patch:
> https://lore.kernel.org/patchwork/patch/1053953/
> 
> 
> It's you who added the Cc: tags
> (and I am guessing you did it by scripting.)
> 
> Why is this topic related to checkpatch?

Because I regularly check all patches with checkpatch but checkpatch
failed to detect that I had

Signed-off-by: Douglas Anderson <dianders@...omium.org>
...
Cc: Douglas Anderson <dianders@...omium.org>

and I believe that checkpatch could and should have warned about this
situation.