linux-kernel - Re: [PATCH -next] drm/panfrost: Make panfrost_gem_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fc55e8c-f021-f235-69e3-25e8c82edb99@collabora.com>
Date:   Thu, 18 Apr 2019 08:42:14 +0200
From:   Tomeu Vizoso <tomeu.vizoso@...labora.com>
To:     Steven Price <steven.price@....com>,
        Yue Haibing <yuehaibing@...wei.com>, robh@...nel.org,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/panfrost: Make panfrost_gem_free_object()
 static

Both patches are:

Reviewed-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>

Thanks!

On 4/17/19 4:51 PM, Steven Price wrote:
> On 16/04/2019 16:00, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@...wei.com>
>>
>> Fix sparse warning:
>>
>> drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
>>   warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Reviewed-by: Steven Price <steven.price@....com>
> 
> Although while we're fixing sparse warnings, there's a few more in Panfrost:
> 
> -----8<-------
>  From 8aaf778262744cfbebb9b7f274ead9ba600526b0 Mon Sep 17 00:00:00 2001
> From: Steven Price <steven.price@....com>
> Date: Wed, 17 Apr 2019 15:47:49 +0100
> Subject: [PATCH] drm/panfrost: Add missing include
> 
> Fix sparse warnings:
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:133:5:
>   warning: symbol 'panfrost_devfreq_init' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:168:6:
>   warning: symbol 'panfrost_devfreq_resume' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:182:6:
>   warning: symbol 'panfrost_devfreq_suspend' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:212:6:
>   warning: symbol 'panfrost_devfreq_record_transition' was not declared. Should it be static?
> 
> Signed-off-by: Steven Price <steven.price@....com>
> ---
>   drivers/gpu/drm/panfrost/panfrost_devfreq.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> index a8121ae67ee3..238bd1d89d43 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> @@ -7,6 +7,7 @@
>   #include <linux/regulator/consumer.h>
>   
>   #include "panfrost_device.h"
> +#include "panfrost_devfreq.h"
>   #include "panfrost_features.h"
>   #include "panfrost_issues.h"
>   #include "panfrost_gpu.h"
>