lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Apr 2019 08:59:15 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Fuqian Huang <huangfq.daxian@...il.com> Cc: Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v5 02/02] tty: rocket: deprecate the rp_ioctl On Thu, Apr 18, 2019 at 12:35:58PM +0800, Fuqian Huang wrote: > This patch depends on patch 01. THat's implied as it is patch 02/02, so no need to put it in the changelog text :) > > The rp_ioctl is deprecated. > Add dev_warn_ratelimited to warn the use of rp_ioctl. > > Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com> > --- > drivers/tty/rocket.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c > index b6543e28bd8b..1e1bcb54b680 100644 > --- a/drivers/tty/rocket.c > +++ b/drivers/tty/rocket.c > @@ -1284,18 +1284,28 @@ static int rp_ioctl(struct tty_struct *tty, > > switch (cmd) { > case RCKP_GET_CONFIG: > + dev_warn_ratelimited(tty->dev, > + "RCKP_GET_CONFIG option is deprecated\n"); Nit, you can wrap this a bit nicer to make checkpatch.pl happy: dev_warn_ratelimited(tty->dev, "RCKP_GET_CONFIG option is deprecated\n"); I'll fix it up when I apply it, thanks! greg k-h
Powered by blists - more mailing lists