linux-kernel - Re: [PATCH v2] staging: greybus: power_supply: use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3zhonpu3e.fsf@gmail.com>
Date:   Thu, 18 Apr 2019 09:59:17 +0100
From:   Rui Miguel Silva <rmfrfs@...il.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: greybus: power_supply: use struct_size() helper

Oi Gustavo,
Thanks for the patch, and the rebasing.

On Wed 17 Apr 2019 at 19:44, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded 
> version
> in order to avoid any potential type mistakes, in particular in 
> the
> context in which this code is being used.
>
> So, replace code of the following form:
>
> sizeof(*resp) + props_count * sizeof(struct 
> gb_power_supply_props_desc)
>
> with:
>
> struct_size(resp, props, props_count)
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>

---
Cheers,
	Rui


> ---
> Changes in v2:
>  - Rebase on top of 47830c1127ef ("staging: greybus: 
>  power_supply: fix prop-descriptor request size")
>
>  drivers/staging/greybus/power_supply.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/power_supply.c 
> b/drivers/staging/greybus/power_supply.c
> index ae5c0285a942..34b40a409ea3 100644
> --- a/drivers/staging/greybus/power_supply.c
> +++ b/drivers/staging/greybus/power_supply.c
> @@ -520,8 +520,8 @@ static int 
> gb_power_supply_prop_descriptors_get(struct gb_power_supply 
> *gbpsy)
>  
>  	op = gb_operation_create(connection,
>  				 GB_POWER_SUPPLY_TYPE_GET_PROP_DESCRIPTORS,
> -				 sizeof(*req), sizeof(*resp) + 
> props_count *
> -				 sizeof(struct 
> gb_power_supply_props_desc),
> +				 sizeof(*req),
> +				 struct_size(resp, props, 
> props_count),
>  				 GFP_KERNEL);
>  	if (!op)
>  		return -ENOMEM;