linux-kernel - Re: [PATCH] ntp: Allow TAI-UTC offset to be set to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1904181106150.3174@nanos.tec.linutronix.de>
Date:   Thu, 18 Apr 2019 11:07:14 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Miroslav Lichvar <mlichvar@...hat.com>
cc:     Ondrej Mosnacek <omosnace@...hat.com>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        John Stultz <john.stultz@...aro.org>,
        Richard Cochran <richardcochran@...il.com>,
        Prarit Bhargava <prarit@...hat.com>
Subject: Re: [PATCH] ntp: Allow TAI-UTC offset to be set to zero

On Thu, 18 Apr 2019, Miroslav Lichvar wrote:
> On Wed, Apr 17, 2019 at 11:00:23AM +0200, Ondrej Mosnacek wrote:
> > On Wed, Apr 17, 2019 at 10:48 AM Miroslav Lichvar <mlichvar@...hat.com> wrote:
> > > Change the ADJ_TAI check to accept zero as a valid TAI-UTC offset in
> > > order to allow setting it back to the initial value.
> 
> > Thanks for sending the patch! Maybe you (or the committer) could
> > consider adding:
> > 
> > Fixes: 153b5d054ac2 ("ntp: support for TAI")
> 
> To me the change looks more like an extension of the API, rather than
> a bug fix, so I'd leave that up to the committer.

I don't see why we need to backport that all the way, but I'm happy to add
the tag if there is some really good reason.

Thanks,

	tglx