linux-kernel - Re: [RFC PATCH v4 4/4] x86/acrn: Add hypercall for ACRN guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Apr 2019 12:11:36 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Zhao Yakui <yakui.zhao@...el.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
        Jason Chen CJ <jason.cj.chen@...el.com>
Subject: Re: [RFC PATCH v4 4/4] x86/acrn: Add hypercall for ACRN guest

On Mon, Apr 15, 2019 at 10:00:57AM +0800, Zhao Yakui wrote:
> When ACRN hypervisor is detected, the hypercall is needed so that the
> ACRN guest can query/config some settings. For example: it can be used
> to query the resources in hypervisor and manage the CPU/memory/device/
> interrupt for guest operating system.
> 
> Add the hypercall so that the kernel can communicate with the low-level
> ACRN hypervisor. It is implemented with vmacll instruction.

This still has unfixed stuff from 2 review cycles ago.

Thomas corrected this in his review to:

"is implemented with the VMCALL instruction"

https://lkml.kernel.org/r/alpine.DEB.2.21.1904052110370.1802@nanos.tec.linutronix.de

You ignored it.

I reminded you about it and suggested to check and incorporate *all*
review feedback before sending another version:

https://lkml.kernel.org/r/20190408151010.GI15689@zn.tnic

You ignored it again.

Now, if you get ignored, you know why, right?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.