[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190418101606.GC6702@sirena.org.uk>
Date: Thu, 18 Apr 2019 11:16:06 +0100
From: Mark Brown <broonie@...nel.org>
To: Eric Jeong <eric.jeong.opensource@...semi.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh+dt@...nel.org>,
DEVICETREE <devicetree@...r.kernel.org>,
LINUX-KERNEL <linux-kernel@...r.kernel.org>,
Mark Rutland <mark.rutland@....com>,
Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH V2 3/3] regulator: slg51000: add slg51000 regulator driver
On Thu, Apr 18, 2019 at 03:09:44PM +0900, Eric Jeong wrote:
> I updated regulator_ops structure to use use the helper function
> which is regulator_is_enabled_regmap() instead reading status bits
> for is_enabled() operation.
> v2: use regulator helper function for is_enabled()
There's also the get_status() operation which you should be able to
implement using the status bits you were reading before - that lets
the framework know if the regualtor is actually working which can help
with error handling so it's good to do.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists