linux-kernel - Re: [linux-sunxi] Re: [PATCH v3 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Tie GMAC regulators to the PIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <666caeac-4297-17b0-065e-00b7fd9623b4@centosproject.org>
Date:   Thu, 18 Apr 2019 09:25:19 -0300
From:   Pablo Sebastián Greco <pgreco@...tosproject.org>
To:     maxime.ripard@...tlin.com
Cc:     linux-sunxi@...glegroups.com, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Chen-Yu Tsai <wens@...e.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [linux-sunxi] Re: [PATCH v3 1/7] ARM: dts: sun8i: r40:
 bananapi-m2-ultra: Tie GMAC regulators to the PIO


El 17/4/19 a las 07:17, Maxime Ripard escribió:
> Hi,
>
> On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote:
>> When the GMAC support was added to the bananapi-m2-ultra, regulators
>> weren't tied to the pinctrl. Fix that.
>>
>> Signed-off-by: Pablo Greco <pgreco@...tosproject.org>
>> ---
>>   arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
>> index c488aaa..3da3598 100644
>> --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
>> +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
>> @@ -201,6 +201,8 @@
>>   &pio {
>>   	pinctrl-names = "default";
>>   	pinctrl-0 = <&clk_out_a_pin>;
>> +	vcc-pa-supply = <&reg_aldo2>;
> You should list all the regulators that are needed for all the pin
> banks to operate properly, not just PA
Ok, I "think" I finally understand what you mean, so according to 
schematics in 
https://drive.google.com/file/d/0B4PAo2nW2KfndFpmZG1OOWJ5NEU/view, it 
should look like this
diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts 
b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
index c488aaa..699579d 100644
--- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
+++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
@@ -201,6 +201,12 @@
  &pio {
      pinctrl-names = "default";
      pinctrl-0 = <&clk_out_a_pin>;
+    vcc-pa-supply = <&reg_aldo2>;
+    vcc-pc-supply = <&reg_dcdc1>;
+    vcc-pd-supply = <&reg_dcdc1>;
+    vcc-pe-supply = <&reg_eldo1>;
+    vcc-pf-supply = <&reg_dcdc1>;
+    vcc-pg-supply = <&reg_dldo1>;
  };

  &reg_aldo2 {
-- 

I couldn't find vcc-pb, vcc-ph or vcc-pi.
If this is ok, I'll generate a v4 based on v2, and throw v3 in the trash 
where it belongs
>> +	vcc-gmac-phy-supply = <&reg_dc1sw>;
> I'm not sure what that is supposed to do?
>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
Pablo.