linux-kernel - Re: [PATCH RFC] staging: vc04_services: handle kzalloc failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf13c010-745d-8c0b-c73f-2dacb26e3346@i2se.com>
Date:   Thu, 18 Apr 2019 14:34:32 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Nicholas Mc Guire <hofrat@...dl.org>, Eric Anholt <eric@...olt.net>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Phil Elwell <phil@...pberrypi.org>,
        linux-kernel@...r.kernel.org,
        Tobias Buettner <tobias.buettner@....de>,
        Luis Chamberlain <mcgrof@...nel.org>,
        linux-rpi-kernel@...ts.infradead.org,
        Dominic Braun <inf.braun@....de>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH RFC] staging: vc04_services: handle kzalloc failure

On 18.04.19 12:29, Nicholas Mc Guire wrote:
> The kzalloc here was being used without checking the return - if the
> kzalloc fails return VCHIQ_ERROR. The call-site of
> vchiq_platform_init_state() vchiq_init_state() was not responding
> to an allocation failure so checks for != VCHIQ_SUCCESS
> and pass VCHIQ_ERROR up to vchiq_platform_init() which then
> will fail with -EINVAL.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>

Acked-by: Stefan Wahren <stefan.wahren@...e.com>