linux-kernel - Re: [tip:sched/core] sched/core: Make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190418124836.GB104512@gmail.com>
Date:   Thu, 18 Apr 2019 14:48:36 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, hpa@...or.com, peterz@...radead.org,
        yuehaibing@...wei.com
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched/core: Make some functions static


* tip-bot for YueHaibing <tipbot@...or.com> wrote:

> Commit-ID:  16e671afb70f28eb189136d1395c59dafecd270a
> Gitweb:     https://git.kernel.org/tip/16e671afb70f28eb189136d1395c59dafecd270a
> Author:     YueHaibing <yuehaibing@...wei.com>
> AuthorDate: Fri, 22 Mar 2019 22:31:53 +0800
> Committer:  Ingo Molnar <mingo@...nel.org>
> CommitDate: Thu, 18 Apr 2019 14:19:25 +0200
> 
> sched/core: Make some functions static
> 
> Fix these sparse warnings:
> 
>   kernel/sched/core.c:6576:11: warning: symbol 'max_cfs_quota_period' was not declared. Should it be static?
>   kernel/sched/core.c:6577:11: warning: symbol 'min_cfs_quota_period' was not declared. Should it be static?
>   kernel/sched/core.c:6657:5: warning: symbol 'tg_set_cfs_quota' was not declared. Should it be static?
>   kernel/sched/core.c:6670:6: warning: symbol 'tg_get_cfs_quota' was not declared. Should it be static?
>   kernel/sched/core.c:6683:5: warning: symbol 'tg_set_cfs_period' was not declared. Should it be static?
>   kernel/sched/core.c:6693:6: warning: symbol 'tg_get_cfs_period' was not declared. Should it be static?
>   kernel/sched/fair.c:2596:6: warning: symbol 'task_tick_numa' was not declared. Should it be static?

So unless this is somehow version dependent or other changes interfered, 
this patch wasn't tested very well:

 kernel/sched/fair.o: In function `sched_cfs_period_timer':
 fair.c:(.text+0x920c): undefined reference to `max_cfs_quota_period'
 fair.c:(.text+0x9214): undefined reference to `max_cfs_quota_period'

skipping it for now.

Thanks,

	Ingo