linux-kernel - Re: [PATCH 3/3] edac: sifive: Add EDAC platform driver for SiFive SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190418125015.GI27160@zn.tnic>
Date:   Thu, 18 Apr 2019 14:50:15 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Yash Shah <yash.shah@...ive.com>
Cc:     devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
        robh+dt@...nel.org, mark.rutland@....com, palmer@...ive.com,
        aou@...s.berkeley.edu, paul.walmsley@...ive.com,
        mchehab@...nel.org, james.morse@....com, sachin.ghadi@...ive.com
Subject: Re: [PATCH 3/3] edac: sifive: Add EDAC platform driver for SiFive
 SoCs

On Mon, Apr 15, 2019 at 05:10:43PM +0530, Yash Shah wrote:
> This initial ver of EDAC driver supports:
> - ECC event monitoring and reporting through the EDAC framework for SiFive
>   L2 cache controller.
> 
> This driver registers for notifier events from the L2 cache controller
> driver (arch/riscv/mm/sifive_l2_cache.c) for L2 ECC events
> 
> Signed-off-by: Yash Shah <yash.shah@...ive.com>
> ---
>  arch/riscv/Kconfig         |   1 +
>  drivers/edac/Kconfig       |   6 +++
>  drivers/edac/Makefile      |   1 +
>  drivers/edac/sifive_edac.c | 121 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 129 insertions(+)
>  create mode 100644 drivers/edac/sifive_edac.c

Please add a MAINTAINERS entry like the other EDAC drivers do so that
you can get CCed on patches/bug reports.

The rest looks ok to me.

I'd still like for James to have a look too, when he gets to it.

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.