linux-kernel - RE: [PATCH v7 04/21] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43db378b84c54908bd2fbf305dd9f8ec@AcuMS.aculab.com>
Date:   Thu, 18 Apr 2019 13:26:15 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     David Laight <David.Laight@...LAB.COM>,
        'Thomas Gleixner' <tglx@...utronix.de>
CC:     'Fenghua Yu' <fenghua.yu@...el.com>,
        'Ingo Molnar' <mingo@...hat.com>,
        'Borislav Petkov' <bp@...en8.de>,
        'H Peter Anvin' <hpa@...or.com>,
        "'Paolo Bonzini'" <pbonzini@...hat.com>,
        'Dave Hansen' <dave.hansen@...el.com>,
        'Ashok Raj' <ashok.raj@...el.com>,
        'Peter Zijlstra' <peterz@...radead.org>,
        'Ravi V Shankar' <ravi.v.shankar@...el.com>,
        'Xiaoyao Li ' <xiaoyao.li@...el.com>,
        'Christopherson Sean J' <sean.j.christopherson@...el.com>,
        'Kalle Valo' <kvalo@...eaurora.org>,
        'Michael Chan' <michael.chan@...adcom.com>,
        'linux-kernel' <linux-kernel@...r.kernel.org>,
        'x86' <x86@...nel.org>,
        "'kvm@...r.kernel.org'" <kvm@...r.kernel.org>,
        "'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
        "'linux-wireless@...r.kernel.org'" <linux-wireless@...r.kernel.org>
Subject: RE: [PATCH v7 04/21] x86/split_lock: Align x86_capability to unsigned
 long to avoid split locked access

From: David Laight
> Sent: 18 April 2019 14:15
...
> Running
> grep -r --include '*.[ch]' '_bit([^(]*, *([^)]* ' .
> over the entire kernel source tree shows quite a few 'dubious' casts.
> 
> They'll be doubly dubious on BE systems.

The alternate pattern:
grep -r --include '*.[ch]' '_bit([^(]*, *([^)]*\*)' .
has a few less false positives and detects some extras with (void*)&foo->bar.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)