linux-kernel - Re: [PATCH v2 1/2] hwmon: (ina3221) Do not read-back to cache reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190418133749.GA13515@roeck-us.net>
Date:   Thu, 18 Apr 2019 06:37:49 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Nicolin Chen <nicoleotsuka@...il.com>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, corbet@....net,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 1/2] hwmon: (ina3221) Do not read-back to cache
 reg_config

On Wed, Apr 17, 2019 at 04:12:09PM -0700, Nicolin Chen wrote:
> Reading back the CONFIG register increases an extra I2C
> transaction. This's not necessary and could be replaced
> with a local variable caching the register settings.
> 
> So this patch replaces two readback regmap_read() calls
> with a tmp variable.
> 
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>

Applied to hwmon-next.

Thanks,
Guenter