linux-kernel - Re: [PATCH -next] drm/panfrost: Make panfrost_gem_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+5R3WWk-CmagO9=HE2nqPyGoHJ9aankYWh2ZOSO+k=eA@mail.gmail.com>
Date:   Thu, 18 Apr 2019 09:32:44 -0500
From:   Rob Herring <robh@...nel.org>
To:     Steven Price <steven.price@....com>
Cc:     Yue Haibing <yuehaibing@...wei.com>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH -next] drm/panfrost: Make panfrost_gem_free_object() static

On Wed, Apr 17, 2019 at 9:51 AM Steven Price <steven.price@....com> wrote:
>
> On 16/04/2019 16:00, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@...wei.com>
> >
> > Fix sparse warning:
> >
> > drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
> >  warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
> >
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>
> Reviewed-by: Steven Price <steven.price@....com>
>
> Although while we're fixing sparse warnings, there's a few more in Panfrost:
>
> -----8<-------
> From 8aaf778262744cfbebb9b7f274ead9ba600526b0 Mon Sep 17 00:00:00 2001
> From: Steven Price <steven.price@....com>
> Date: Wed, 17 Apr 2019 15:47:49 +0100
> Subject: [PATCH] drm/panfrost: Add missing include
>
> Fix sparse warnings:
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:133:5:
>  warning: symbol 'panfrost_devfreq_init' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:168:6:
>  warning: symbol 'panfrost_devfreq_resume' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:182:6:
>  warning: symbol 'panfrost_devfreq_suspend' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:212:6:
>  warning: symbol 'panfrost_devfreq_record_transition' was not declared. Should it be static?
>
> Signed-off-by: Steven Price <steven.price@....com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.