linux-kernel - Re: [PATCH] crypto: ccp: Do not free psp_master when PLATFORM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190418142337.hrdykxre3g5bvjbz@gondor.apana.org.au>
Date:   Thu, 18 Apr 2019 22:23:37 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     "Singh, Brijesh" <brijesh.singh@....com>
Cc:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "Hook, Gary" <Gary.Hook@....com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] crypto: ccp: Do not free psp_master when PLATFORM_INIT
 fails

On Mon, Apr 08, 2019 at 08:42:55PM +0000, Singh, Brijesh wrote:
> Currently, we free the psp_master if the PLATFORM_INIT fails during the
> SEV FW probe. If psp_master is freed then driver does not invoke the PSP
> FW. As per SEV FW spec, there are several commands (PLATFORM_RESET,
> PLATFORM_STATUS, GET_ID etc) which can be executed in the UNINIT state
> We should not free the psp_master when PLATFORM_INIT fails.
> 
> Fixes: 200664d5237f ("crypto: ccp: Add SEV support")
> Cc: Tom Lendacky <thomas.lendacky@....com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Gary Hook <gary.hook@....com>
> Cc: stable@...r.kernel.org # 4.19.y
> Signed-off-by: Brijesh Singh <brijesh.singh@....com>
> ---
>  drivers/crypto/ccp/psp-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt